Additional listener should inherit the configured authentication method#7594
Merged
eddumelendez merged 8 commits intotestcontainers:mainfrom Sep 28, 2023
Merged
Additional listener should inherit the configured authentication method#7594eddumelendez merged 8 commits intotestcontainers:mainfrom
eddumelendez merged 8 commits intotestcontainers:mainfrom
Conversation
lburgazzoli
changed the title
Member
eddumelendez
left a comment
eddumelendez
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @lburgazzoli! Those block are needed for our docs but using existing one will break the documentation.
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java
Outdated
Show resolved
Hide resolved
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java
Outdated
Show resolved
Hide resolved
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java
Outdated
Show resolved
Hide resolved
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java
Outdated
Show resolved
Hide resolved
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java
Outdated
Show resolved
Hide resolved
…pandaContainerTest.java
…pandaContainerTest.java
…pandaContainerTest.java
…pandaContainerTest.java
…pandaContainerTest.java
modules/redpanda/src/main/java/org/testcontainers/redpanda/RedpandaContainer.java
Outdated
Show resolved
Hide resolved
…pandaContainer.java
eddumelendez
approved these changes
Sep 28, 2023
Member
|
Thanks again, @lburgazzoli! This is now merged in |
Contributor
Author
|
@eddumelendez thx for fixing up my mistakes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement the enhancement proposed in #7531 by setting the
authentication_methodfor the additional listeners to the authentication method configured when sasl is enabled.Fixes #7531