Skip to content

Deprecate withSecretInVault#7576

Merged
eddumelendez merged 1 commit intomainfrom
deprecate-withsecretinvault
Sep 25, 2023
Merged

Deprecate withSecretInVault#7576
eddumelendez merged 1 commit intomainfrom
deprecate-withsecretinvault

Conversation

@eddumelendez
Copy link
Copy Markdown
Member

@eddumelendez eddumelendez commented Sep 25, 2023

Use withInitCommand

It has been been confusing for users the use of withSecreInVault and withInitCommand, see #7532. In order to be aligned with consul module we are encouraging to use just withInitCommand.

Use `withInitCommand`
@eddumelendez eddumelendez requested a review from a team September 25, 2023 15:49
@eddumelendez eddumelendez added this to the next milestone Sep 25, 2023
@eddumelendez eddumelendez added the type/deprecation Public APIs are being deprecated but not changed yet label Sep 25, 2023
@eddumelendez eddumelendez merged commit 5d0631f into main Sep 25, 2023
@eddumelendez eddumelendez deleted the deprecate-withsecretinvault branch September 25, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modules/vault type/deprecation Public APIs are being deprecated but not changed yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant