Repository navigation
Conversation
This is related to testcontainers#5837, though I'm not sure if it fully fixes it. This makes two changes that make testcontainers work with Colima with no configuration for me: - Since v3.3 docker-java supports looking in the context file to discover the Docker host, but EnvironmentAndSystemPropertyClientProviderStrategy ignored that. This change makes it so that if `DefaultDockerClientConfig.Builder.build` ever returns a non-default docker-host, it is used. - With Colima, the path that you use to refer to the docker socket when setting up container volumes is different from the path you use to directly connect to Docker, because within the VM, you just use the standard `/var/run/docker.sock`. Add some hardcoded logic to always use `/var/run/docker.sock` if the chosen socket appears to be from Colima; you can always override with $TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE.
Member
Author
|
It does work on my computer, though I see that your PR there actually tests it in Colima, which is great. I guess we can use my fork in my project for now, if it seems like testcontainers-java is likely to support Colima relatively soon! |
|
@eddumelendez It's been a while since this was in motion, but are you aware of any current work to support this? The node PR you linked was closed and I am unable to find any updates or direction (if there is any) on work to support Colima properly. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #5837, though I'm not sure if it fully fixes it.
This makes two changes that make testcontainers work with Colima with no configuration for me:
DefaultDockerClientConfig.Builder.buildever returns a non-default docker-host, it is used./var/run/docker.sock. Add some hardcoded logic to always use/var/run/docker.sockif the chosen socket appears to be from Colima; you can always override with $TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE.