Skip to content

Add tc. prefix to container logger names#6781

Merged
eddumelendez merged 2 commits intomainfrom
container_logger
Mar 14, 2023
Merged

Add tc. prefix to container logger names#6781
eddumelendez merged 2 commits intomainfrom
container_logger

Conversation

@eddumelendez
Copy link
Copy Markdown
Member

@eddumelendez eddumelendez commented Mar 14, 2023 •
edited
Loading

Fixes #3016

Vitalii Chura and others added 2 commits March 14, 2023 11:57
@eddumelendez
Add docker. prefix to container logger names (#3016)
b1dc70b 
Update logger name used by containers

fix formatting

remove unnecessary logger from logbacks
@eddumelendez
Polish contribution
2ac3e57
@eddumelendez eddumelendez requested a review from a team March 14, 2023 18:05
@eddumelendez eddumelendez changed the title container logger Add tc. prefix to container logger names Mar 14, 2023
@eddumelendez eddumelendez mentioned this pull request Mar 14, 2023
Closed
@eddumelendez eddumelendez added this to the next milestone Mar 14, 2023
@eddumelendez eddumelendez merged commit 209e53b into main Mar 14, 2023
@eddumelendez eddumelendez deleted the container_logger branch March 14, 2023 18:46
@perlun
Copy link
Copy Markdown
Contributor

perlun commented Mar 17, 2023

At last! Greatly appreciated, @eddumelendez. 🙂 👍

@sideeffffect
Copy link
Copy Markdown

sideeffffect commented Mar 20, 2023

Thanks a lot for this! When can we expect a new release containing this fix?

@perlun
Copy link
Copy Markdown
Contributor

perlun commented Apr 11, 2023

Thanks a lot for this! When can we expect a new release containing this fix?

For reference, https://github.com/testcontainers/testcontainers-java/releases/tag/1.18.0 was released last week which includes this fix. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type/docs type/enhancement

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

Loggers provided by DockerLoggerFactory inherit from root logger instead of custom loggers

3 participants

@eddumelendez @perlun @sideeffffect