Ensure readability of MySQL and MariaDB config override#6625
Ensure readability of MySQL and MariaDB config override#6625eddumelendez merged 1 commit intotestcontainers:mainfrom
Conversation
|
The credit is all yours my friend! |
eddumelendez
left a comment
eddumelendez
left a comment
There was a problem hiding this comment.
I've left just one question. Just want to make sure the test is needed due to, previously, testMySQLWithCustomIniFile used to fail for MariaDBContainer and MySQLContainer and now it passes when running on Codespaces.
| } | ||
|
|
||
| @Test | ||
| public void testWithOnlyUserReadableCustomIniFile() throws Exception { |
There was a problem hiding this comment.
Should I be able to reproduce this setting umask with 027, right?
There was a problem hiding this comment.
Yeah, the test kinda only an "emulation" but I tested my real world setup with this fix using umask 0027.
There was a problem hiding this comment.
PS: I also did run this new test before and after the fix; before the fix it failed and now it passes.
|
Thanks for your contribution, @famod ! This is now merged in |
3 participants
Fixes #914, fixes #4952, supersedes (and heavily based on) #5401.
Most credits to @driverpt!