Repository navigation
Clarify docker-socket mounting workaround for Docker Desktop - #6282
Merged
Merged
Conversation
eddumelendez
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker Desktop changed some internal network details regarding quite some time ago (see this comment). We raised the issue in the upstream, since Testcontainers users were discovering this in Docker-Wormhole setups, but the workaround used to fail on WSL2 back in the day.
Nowadays, the workaround also works fine on WSL2 and since this implementation works as intended by the upstream and we used to rely on undefined behavior before, I'd say the workaround is the actual correct approach how to do. Hence this PR adds it to our documentation.
Closes #4395.