Avoid Pattern recompilation in log output processing#6239
Merged
eddumelendez merged 1 commit intotestcontainers:mainfrom Nov 29, 2022
Merged
Avoid Pattern recompilation in log output processing#6239eddumelendez merged 1 commit intotestcontainers:mainfrom
eddumelendez merged 1 commit intotestcontainers:mainfrom
Conversation
kiview
approved these changes
Nov 28, 2022
Member
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
Thanks for the focused PR @dreis2211.
eddumelendez
approved these changes
Nov 29, 2022
Member
|
Thanks for your contribution @dreis2211 ! PR is already merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been doing some profiling and noticed an admittedly small - but avoidable - amount of allocations coming from testcontainers when processing log outputs.
This PR avoids recompiling patterns and the corresponding allocations.
Cheers,
Christoph