feat: enable reuse for mongodb#6235
Merged
eddumelendez merged 3 commits intotestcontainers:mainfrom Dec 2, 2022
Merged
Conversation
tiboun
force-pushed
the
feat/enable-reuse-for-mongodb
branch
from
fda22d4 to
d38dcb4
Compare
Member
|
Thanks for the PR @tiboun. We have a different |
tiboun
force-pushed
the
feat/enable-reuse-for-mongodb
branch
from
d38dcb4 to
3911244
Compare
Contributor
Author
|
Hi @kiview , I've updated my MR to use the method mentionned. Let me know if it is correctly implemented :) |
tiboun
force-pushed
the
feat/enable-reuse-for-mongodb
branch
from
3911244 to
b3a7d86
Compare
eddumelendez
approved these changes
Dec 2, 2022
Member
|
Thanks for your contribution @tiboun ! I added two commits in order to polish the contribution a little bit and fix a check. This is now in |
Contributor
Author
|
Thx @eddumelendez ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we reuse container with mongodb images, it fails the first time we reuse it because the replica is already set, hence the exit code of the replica set is 1 and not 0.
In order to avoid that, a check is made on the state of the current node.
If the command fails because there is no replica, it will fallback to the initialisation of the replica set like today.
Otherwise, it will skip.
In order to know if a replica is set or not, since we are working with one node, it must be a primary one.
We use replSetGetStatus to check its "myState" attribute.