Short-circuit CompletableFuture returned by Startables#deepStart on exception#5930
Merged
eddumelendez merged 2 commits intotestcontainers:mainfrom Jan 14, 2023
pivovarit:deepstart-shortcircuit
Merged
Short-circuit CompletableFuture returned by Startables#deepStart on exception#5930eddumelendez merged 2 commits intotestcontainers:mainfrom pivovarit:deepstart-shortcircuit
eddumelendez merged 2 commits intotestcontainers:mainfrom
pivovarit:deepstart-shortcircuit
Conversation
eddumelendez
approved these changes
Jan 14, 2023
Member
|
Sorry for the delay and thanks for the contribution @pivovarit ! This is now merged in main branch and will be available in the next release. |
Contributor
Author
|
No worries, I know how it is to maintain OSS projects :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompletableFuture.allOfreturns a future that completes only when all provided futures complete either successfully or exceptionally, which means that when one future fails, you still need to wait until the remaining futures complete... only to be presented with the exception that failed at the beginning.This is safe, according to JMM.
Fixes: #2249
Recycled #2251