Removed deprecated methods and undeclared transitive dependency to AWS SDK v1#5827
Merged
eddumelendez merged 3 commits intotestcontainers:mainfrom Feb 16, 2023
AB-xdev:fix-4279-noclassdef
Merged
Removed deprecated methods and undeclared transitive dependency to AWS SDK v1#5827eddumelendez merged 3 commits intotestcontainers:mainfrom AB-xdev:fix-4279-noclassdef
eddumelendez merged 3 commits intotestcontainers:mainfrom
AB-xdev:fix-4279-noclassdef
Conversation
Member
|
thanks for the PR @AB-xdev ! We are not planning to remove it for now but for 2.0. |
Member
|
Thanks for your contribution, @AB-xdev ! This is now merged in |
Contributor
|
@eddumelendez do you know when it will be released? I use AWS SDK v2 and I would like not to have import v1. |
|
Hi @eddumelendez I couldn't find any mention in this repo of following semver or any other versioning policy, can you please direct me to it? I'm asking because this PR was merged as part of the 1.18.0 release, and the removal of the deprecated methods is a breaking change. Just want to understand how I should interpret the release notes when considering upgrading a specific module version in my projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4279.
The problem:
The localstack module has an undeclared dependency to parts of the AWS SDK v1 which causes the above issue.
While the methods have been deprecated with #5489, this still doesn't fix the class loading problems.
The fix:
The removal of the deprecated methods, corresponding imports and dependencies should fix the class loading problems.