JdbcDatabaseContainer: fix wrong instance call#5465
Merged
eddumelendez merged 2 commits intotestcontainers:masterfrom Jun 27, 2022
Merged
JdbcDatabaseContainer: fix wrong instance call#5465eddumelendez merged 2 commits intotestcontainers:masterfrom
eddumelendez merged 2 commits intotestcontainers:masterfrom
Conversation
createConnection() method calls a wrong driver instance when logging
Contributor
Author
|
That's an a bit lazy-ass fix made from GitHub's interface. It can be covered with a test case, but I'd have to checkout the project to do that. Let me know if you want me to do that 🙂 |
kiview
approved these changes
Jun 27, 2022
Member
|
Thx @monosoul, LGTM |
Member
|
@monosoul thank you for your contribution! this is now in master |
monosoul
added a commit
to monosoul/jooq-gradle-plugin
that referenced
this pull request
Jul 14, 2022
monosoul
added a commit
to monosoul/jooq-gradle-plugin
that referenced
this pull request
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createConnection() method calls a wrong driver instance when logging.
Reason behind this fix: if you override method
getJdbcDriverInstance, you will get an exception here.