Skip to content

MySQL: Fix problem of starting up mysql 5.7.33 version when user is root #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnorth merged 5 commits into from
Apr 11, 2021
Merged

MySQL: Fix problem of starting up mysql 5.7.33 version when user is root #3953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34c2bc7
Fix problem of starting up mysql 5.7.33 version when user is root
Mar 31, 2021
d099862
Fix typo
Mar 31, 2021
32a7629
Add test that checks root account usage for mysql version 8 and 5
Apr 9, 2021
03151ea
Use empty string instead of null password
seveneves Apr 10, 2021
8b76f3f
Add check that root account is used
seveneves Apr 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions modules/mysql/src/main/java/org/testcontainers/containers/MySQLContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,12 @@ protected Set<Integer> getLivenessCheckPorts() {
@Override
protected void configure() {
optionallyMapResourceParameterAsVolume(MY_CNF_CONFIG_OVERRIDE_PARAM_NAME, "/etc/mysql/conf.d",
"mysql-default-conf");
"mysql-default-conf");

addEnv("MYSQL_DATABASE", databaseName);
addEnv("MYSQL_USER", username);
if (!MYSQL_ROOT_USER.equalsIgnoreCase(username)) {
addEnv("MYSQL_USER", username);
}
if (password != null && !password.isEmpty()) {
addEnv("MYSQL_PASSWORD", password);
addEnv("MYSQL_ROOT_PASSWORD", password);
Expand Down Expand Up @@ -98,12 +100,12 @@ public String getJdbcUrl() {
protected String constructUrlForConnection(String queryString) {
String url = super.constructUrlForConnection(queryString);

if (! url.contains("useSSL=")) {
if (!url.contains("useSSL=")) {
String separator = url.contains("?") ? "&" : "?";
url = url + separator + "useSSL=false";
}

if (! url.contains("allowPublicKeyRetrieval=")) {
if (!url.contains("allowPublicKeyRetrieval=")) {
url = url + "&allowPublicKeyRetrieval=true";
}

Expand Down
53 changes: 53 additions & 0 deletions modules/mysql/src/test/java/org/testcontainers/containers/MySQLRootAccountTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package org.testcontainers.containers;

import lombok.extern.slf4j.Slf4j;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.testcontainers.containers.output.Slf4jLogConsumer;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.SQLException;

@Slf4j
@RunWith(Parameterized.class)
public class MySQLRootAccountTest {

@Parameterized.Parameters(name = "{0}")
public static String[] params() {
return new String[]{
"mysql:8",
"mysql:5"
};
}

@Parameterized.Parameter()
public String image;

@Test
public void testRootAccountUsageWithDefaultPassword() throws SQLException {
testWithDB(new MySQLContainer<>(image).withUsername("root"));
}

@Test
public void testRootAccountUsageWithEmptyPassword() throws SQLException {
testWithDB(new MySQLContainer<>(image).withUsername("root").withPassword(""));
}

@Test
public void testRootAccountUsageWithCustomPassword() throws SQLException {
testWithDB(new MySQLContainer<>(image).withUsername("root").withPassword("not-default"));
}

private void testWithDB(MySQLContainer<?> db) throws SQLException {
try {
db.withLogConsumer(new Slf4jLogConsumer(log)).start();
Connection connection = DriverManager.getConnection(db.getJdbcUrl(), db.getUsername(), db.getPassword());
connection.createStatement().execute("SELECT 1");
connection.createStatement().execute("set sql_log_bin=0"); // requires root
} finally {
db.close();
}
}
}