Skip to content

add github actions to dependabot config#3633

Merged
rnorth merged 2 commits intotestcontainers:masterfrom
jetersen:patch-2
Dec 31, 2020
Merged

add github actions to dependabot config#3633
rnorth merged 2 commits intotestcontainers:masterfrom
jetersen:patch-2

Conversation

@jetersen
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@sullis sullis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's give it a try.

We're keen to ensure that:
(a) GitHub-provided actions are up to date
(b) Non-GitHub, third-party, actions are pinned by commit SHA (because version tags are technically mutable)

The behaviour of dependabot for (b) isn't documented AFAICT. I'm willing to give it a try and see - we can always revert if we decide we don't like the PRs it's raising.

FYI @bsideup, @kiview

@jetersen
Copy link
Copy Markdown
Contributor Author

Dependabot is pretty reasonable if it notes your using v1.1.1 and it will update to v1.2.0

I haven't tried commit sha but technically that is also mutable since you can use force push to remove that commit sha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants