Get region from env variables or default#3556
Merged
eddumelendez merged 6 commits intotestcontainers:masterfrom Jun 2, 2022
Merged
Get region from env variables or default#3556eddumelendez merged 6 commits intotestcontainers:masterfrom
eddumelendez merged 6 commits intotestcontainers:masterfrom
Conversation
adrianpozueco
requested review from
bsideup,
kiview and
rnorth
as code owners
adrianpozueco
force-pushed
the
localstack-region-from-env
branch
from
0e88871 to
811d522
Compare
vcvitaly
reviewed
Mar 11, 2021
...s/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java
Outdated
Show resolved
Hide resolved
adrianpozueco
force-pushed
the
localstack-region-from-env
branch
from
811d522 to
3fce6bf
Compare
rnorth
reviewed
Mar 13, 2021
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Thank you - I think this looks fine. Did you intend to add a documentation update, though? It looks like you've started to prepare for that. If you could add to the localstack module docs it would be perfect - thanks!
Contributor
Author
|
IMHO it’s already documented on:
Do you want me to add a sample with Region? |
|
Any updates on this ? |
eddumelendez
reviewed
Jun 1, 2022
...s/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java
Outdated
Show resolved
Hide resolved
…/localstack/LocalStackContainer.java
eddumelendez
reviewed
Jun 1, 2022
...calstack/src/test/java/org/testcontainers/containers/localstack/LocalstackContainerTest.java
Outdated
Show resolved
Hide resolved
...calstack/src/test/java/org/testcontainers/containers/localstack/LocalstackContainerTest.java
Outdated
Show resolved
Hide resolved
…/localstack/LocalstackContainerTest.java
…/localstack/LocalstackContainerTest.java
eddumelendez
approved these changes
Jun 1, 2022
bsideup
approved these changes
Jun 2, 2022
Member
|
@adrianpozueco thanks for the contribution! this will be available in next Testcontainers release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.