Expose Toxiproxy control port and proxy name#3454
Merged
bsideup merged 2 commits intotestcontainers:masterfrom Dec 10, 2020
aartigao:expose-toxiproxy-name
Merged
Expose Toxiproxy control port and proxy name#3454bsideup merged 2 commits intotestcontainers:masterfrom aartigao:expose-toxiproxy-name
bsideup merged 2 commits intotestcontainers:masterfrom
aartigao:expose-toxiproxy-name
Conversation
In order to work with and external Toxiproxy client we need the control port to get the mapped port and the proxy names to interact with.
bsideup
reviewed
Nov 9, 2020
modules/toxiproxy/src/main/java/org/testcontainers/containers/ToxiproxyContainer.java
Outdated
Show resolved
Hide resolved
Hidden the port constant again and created accessor for Toxiproxy mapped control port.
Contributor
|
LGTM |
bsideup
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3453
In order to work with and external Toxiproxy client we need the control port to get the mapped port and the proxy names to interact with.