Clarify usage of host port exporting#3421
Merged
bsideup merged 1 commit intotestcontainers:masterfrom Feb 6, 2021
Merged
Conversation
This was referenced Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm really glad, I found Testcontainers nice feature of exposing a host port to the containers. However, one thing I stumbled upon was the need to start the server on the host before calling
Testcontainers.exposeHostPorts(hostPort). After looking at the test linked in issue #1136, I found out about this necessity, but I think it would be helpful to add this remark directly to the documentation.What do you think about it?
Best regards
Alex