Skip to content

Startables#deepStart with varargs#3261

Merged
rnorth merged 1 commit intotestcontainers:masterfrom
jochenchrist:master
Dec 12, 2020
Merged

Startables#deepStart with varargs#3261
rnorth merged 1 commit intotestcontainers:masterfrom
jochenchrist:master

Conversation

@jochenchrist
Copy link
Copy Markdown
Contributor

@jochenchrist jochenchrist commented Sep 23, 2020

Support varargs in Startables to start multiple containers in parallel, esp. for singleton pattern.

// instead of     
List<Startable> startables = List.of(mongoDBContainer, kafkaContainer, mockServerContainer);
Startables.deepStart(startables).get();

// this more readable
Startables.deepStart(mongoDBContainer, kafkaContainer, mockServerContainer).get();

rnorth
rnorth approved these changes Dec 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me - sorry it's taken so long to look at, and thanks for the contribution.

@rnorth rnorth merged commit 87da74e into testcontainers:master Dec 12, 2020
@bsideup bsideup added this to the next milestone Feb 6, 2021
This was referenced Mar 13, 2021
Open
Merged
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees

No one assigned

Labels

type/enhancement

Projects

None yet

Milestone

1.15.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jochenchrist @rnorth @bsideup