Make recorder .flv videos scrollable (#512) by oussamabadr · Pull Request #3180 · testcontainers/testcontainers-java

oussamabadr · 2020-08-31T22:18:18Z

I have written an implementation to fix the scrollable video using ffmpeg command, which will also reduce the video size as mentioned by @leonard84

I have also opened a related pull Request testcontainers/vnc-recorder#4 by adding ffmpeg to the docker image, which (I saw) necessary to avoid using another container and also simplify the fix.
Just to mention that some test won't pass untill the new vnc-recorder docker image is available with tag 1.2.0.

(Thank to @kiview for his assitance during hack-commit-push (last june) which make contributing to testcontainers more clear for me.)

Fixes #512.

kiview

Thanks a lot, I have added some discussion point.

Looking forward to getting this quality of life fix merged 🙂

core/src/main/java/org/testcontainers/containers/VncRecordingContainer.java

...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java

core/src/main/java/org/testcontainers/containers/VncRecordingContainer.java

...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java

oussamabadr · 2020-09-06T17:48:19Z

Some tests don't pass :
ChromeWebDriverContainerTest. simpleTest
CustomWaitTimeoutWebDriverContainerTest. simpleTest
SpecificImageNameWebDriverContainerTest. simpleTest

due to ExpectedConditions.visibilityOfAllElementsLocatedBy(By.cssSelector("#search h3") that is not met, but when using just By.cssSelector("#search") all tests pass.

I will try find out why and commit a fix

oussamabadr · 2020-09-20T22:41:54Z

The tests were fixed by changing the Css Selector to look for parent element #search then for child elements with h3 tag (See last commit):

ChromeWebDriverContainerTest. simpleTest
CustomWaitTimeoutWebDriverContainerTest. simpleTest
SpecificImageNameWebDriverContainerTest. simpleTest

rnorth · 2020-09-22T20:11:53Z

Updated docker image is published: https://hub.docker.com/layers/testcontainers/vnc-recorder/1.2.0/images/sha256-1e14fc21b1dd7c28978f82f90008e4a603cc62744631cd299d3f846a08821ea9?context=repo

oussamabadr · 2020-10-10T23:41:34Z

I have updated to use the new testcontainers/vnc-recorder:1.2.0.
I canceled my last fix of about Css Selector due to changes in org.testcontainers.junit.BaseWebDriverContainerTest#doSimpleExplore (and now all tests pass).
I tried to switch to mp4 but some tests was unstable, so I prefer to have a separated ticket for it (I can work on it) and also indicate whether should we make flv available as an option or not for backward compatibility.

...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java

rnorth · 2020-10-13T11:56:15Z

I've merged from master, as we've had a problem with GitHub Actions that needed to be fixed in the master branch.

kiview

Overall looks good, just had some small remarks.

@rnorth
Can you have a final look?

core/src/main/java/org/testcontainers/utility/TestcontainersConfiguration.java

...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java

kiview

@rnorth Can you have a final look?

core/src/main/java/org/testcontainers/containers/VncRecordingContainer.java

rnorth

We had a discussion offline, and decided that we can't risk changing the default emitted file format without warning.

I'll take an action to amend this PR, adding a parameter for format which will default to FLV. In 1.16.0 we'll change the default to MP4.

Sorry that this came as a late decision.

leonard84 · 2020-11-23T13:17:05Z

@rnorth sounds good.

I'll take an action to amend this PR, adding a parameter for format which will default to FLV. In 1.16.0 we'll change the default to MP4.

Just note that it does not suffice to change the extension mp4 requires -movflags faststart to create stream able video.

…RecordingWebDriverContainerTest.java

…tainers#512)

…estcontainers#512)

)

oussamabadr · 2021-02-10T11:52:33Z

Thanks everyone for letting me contribute to this awesome project, hope it will be useful to the community 😃

bsideup · 2021-02-10T11:53:48Z

@oussamabadr thank you so much for contributing it! 💯
The timing was a bit uneasy given the reduced capacity of the team, and I am very sorry it took so long, but we're very happy with the result!

Expect it to be released very soon :)

AB-xdev · 2021-07-27T14:20:11Z

@rnorth

We had a discussion offline, and decided that we can't risk changing the default emitted file format without warning.

I'll take an action to amend this PR, adding a parameter for format which will default to FLV. In 1.16.0 we'll change the default to MP4.

Sorry that this came as a late decision.

1.16.0 got released. However I was unable to spot the change in the release notes.
Was it changed now to MP4 or is it still FLV?

kiview · 2021-07-27T14:24:47Z

@AB-xdev
This PR was released in 1.15.2.

The default is FLV, but you can specify MP4 as well.

AB-xdev · 2021-07-27T14:32:33Z

@kiview

This PR was released in 1.15.2.

The default is FLV, but you can specify MP4 as well.

Thank you for the ultra-fast feedback 👍
However I meant the change that the default format is mp4 (or at least it should be as stated in the comment above).

Backstory:
We have an (non critical) issue in our project that basically says "Change Testcontainer-Test-videos from FLV to MP4".
However we read that you will change it anyways with 1.16.0 and thought that we can simply sit this out and fix it on the fly when we update to 1.16 😄

bsideup · 2021-07-27T14:33:12Z

@AB-xdev we forgot to switch the default in 1.16.0, sorry 😅

AB-xdev · 2021-07-27T14:43:31Z

No problem.

Just a question: Do you still want to switch or not?
If yes, we will sit it out.
If no, we will do it ourself 😄

bsideup · 2021-07-27T14:45:24Z

@AB-xdev we do! It is the right default value and will make many users' lives easier, just we need to do it in a "major" release, to not confuse our users. So, 1.17.0 then 😅

oussamabadr requested review from bsideup, kiview and rnorth as code owners August 31, 2020 22:18

kiview requested changes Sep 1, 2020

View reviewed changes

oussamabadr force-pushed the master branch from 4fbd2fe to a50d156 Compare September 2, 2020 21:15

leonard84 reviewed Sep 2, 2020

View reviewed changes

core/src/main/java/org/testcontainers/containers/VncRecordingContainer.java Outdated Show resolved Hide resolved

oussamabadr requested a review from kiview September 2, 2020 21:38

kiview reviewed Sep 3, 2020

View reviewed changes

oussamabadr force-pushed the master branch from a50d156 to 7008dfd Compare September 6, 2020 14:37

oussamabadr force-pushed the master branch from 7008dfd to 30963c2 Compare September 20, 2020 22:27

oussamabadr requested a review from kiview September 20, 2020 22:35

oussamabadr force-pushed the master branch 2 times, most recently from 4b75c5e to f76e59a Compare October 10, 2020 23:20

oussamabadr force-pushed the master branch from f76e59a to 0af43e0 Compare October 10, 2020 23:51

kiview requested changes Oct 12, 2020

View reviewed changes

...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java Outdated Show resolved Hide resolved

...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java Outdated Show resolved Hide resolved

oussamabadr force-pushed the master branch from 98b7b2a to ae172f5 Compare October 13, 2020 04:03

oussamabadr requested a review from kiview October 13, 2020 12:58

kiview requested changes Nov 9, 2020

View reviewed changes

oussamabadr force-pushed the master branch from eb9a077 to 0fdd4a0 Compare November 15, 2020 19:40

oussamabadr requested a review from kiview November 15, 2020 20:08

kiview reviewed Nov 16, 2020

View reviewed changes

...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java Outdated Show resolved Hide resolved

kiview approved these changes Nov 16, 2020

View reviewed changes

leonard84 reviewed Nov 16, 2020

View reviewed changes

core/src/main/java/org/testcontainers/containers/VncRecordingContainer.java Outdated Show resolved Hide resolved

rnorth requested changes Nov 21, 2020

View reviewed changes

oussamabadr and others added 8 commits February 10, 2021 09:38

Remove third party container + Refactoring (testcontainers#512)

839b3ee

Fixing test after merge with master

16453c2

Fix test [recordingTestThatShouldHaveCorrectDuration] broken in CI

de2f51a

Refactoring

9c384de

Update modules/selenium/src/test/java/org/testcontainers/junit/Chrome…

6382c0b

…RecordingWebDriverContainerTest.java

Add MP4 support for Recorded video + Make FLV default format (testcon…

997d34a

…tainers#512)

Backward compatibility for default Recording format + Add Null check (t…

e093058

…estcontainers#512)

Correct code format + Make video format non nullable (testcontainers#512

01554f0

)

oussamabadr force-pushed the master branch from 3757cfd to 01554f0 Compare February 10, 2021 08:38

cleanups

9ccebb7

bsideup added this to the next milestone Feb 10, 2021

bsideup added modules/selenium type/feature labels Feb 10, 2021

bsideup merged commit a6f91e3 into testcontainers:master Feb 10, 2021

kayb-proxora mentioned this pull request Feb 18, 2021

Could not find the file /newScreen.mp4 #3809

Closed

leonard84 mentioned this pull request Feb 19, 2021

Selenium: Fix mp4 recording to be compatible with Firefox #3812

Merged

Uh oh!

Conversation

oussamabadr commented Aug 31, 2020 • edited by kiview Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kiview left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oussamabadr commented Sep 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oussamabadr commented Sep 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rnorth commented Sep 22, 2020

Uh oh!

oussamabadr commented Oct 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rnorth commented Oct 13, 2020

Uh oh!

kiview left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kiview left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rnorth left a comment

Choose a reason for hiding this comment

Uh oh!

leonard84 commented Nov 23, 2020

Uh oh!

oussamabadr commented Feb 10, 2021

Uh oh!

bsideup commented Feb 10, 2021

Uh oh!

AB-xdev commented Jul 27, 2021

Uh oh!

kiview commented Jul 27, 2021

Uh oh!

AB-xdev commented Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bsideup commented Jul 27, 2021

Uh oh!

AB-xdev commented Jul 27, 2021

Uh oh!

bsideup commented Jul 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

oussamabadr commented Aug 31, 2020 •

edited by kiview

Loading

oussamabadr commented Sep 6, 2020 •

edited

Loading

oussamabadr commented Sep 20, 2020 •

edited

Loading

oussamabadr commented Oct 10, 2020 •

edited

Loading

AB-xdev commented Jul 27, 2021 •

edited

Loading