Migrate postgis image to the postgis/postgis docker hub repo.#2797
Merged
kiview merged 2 commits intotestcontainers:masterfrom Jun 4, 2020
Merged
Migrate postgis image to the postgis/postgis docker hub repo.#2797kiview merged 2 commits intotestcontainers:masterfrom
kiview merged 2 commits intotestcontainers:masterfrom
Conversation
kiview
approved these changes
May 27, 2020
Member
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
Thanks for the PR and the background info about the Docker Hub renaming. I wonder if we have any chance to more gracefully handle the breaking change.
As it seems, the new tag format contains a -, so would it be sensible to check for this in the configure step and log an error, informing the user about the migration? Or is it enough to mention this breaking change in the changelog?
kiview
added
modules/jdbc
type/breaking-api-change
Member
|
Hey @Sanych, because of the breaking nature of this PR, we plan to pull it in for version 1.15.0. Thanks for your efforts. |
Contributor
Author
|
Hey. Are there any thoughts when 1.15 version is expected? |
Member
|
Hi @Sanych, since 1.15 will be the next release, I just merged the PR. You can expect a release "soon" 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello all. mdillon/postigs image was renamed to postgis/postgis few months ago. the discussion. Since that time the image has been updated with new postgres and postgis versions.
I've updated the image name and default version but there is a concern with the tags. Migration to the new image broke tag names backward compatibility with the old one.
Since the new postgis version was added to the repo the image tags were changes. I.e mdillon/postgis:10 became postgis/postgis:10-2.5.