Conversation
bsideup
reviewed
May 7, 2020
.github/workflows/ci-dind.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| name: in-container | |||
| name: CI-DinD | |||
Member
There was a problem hiding this comment.
we're not running "Docker-in-Docker", but mount the socket, hence "in-container" :) Maybe we can use "wormhole" or similar...
bsideup
reviewed
May 7, 2020
Co-authored-by: Sergei Egorov <[email protected]>
bsideup
reviewed
May 13, 2020
| apply plugin: 'ch.myniva.s3-build-cache' | ||
| apply plugin: 'com.gradle.enterprise' | ||
|
|
||
| rootProject.name = 'testcontainers-java' |
Member
There was a problem hiding this comment.
Just to be sure - you just moved these lines without changing them, right? Or was it done by accident and we should probably revert it? :)
Member
Author
There was a problem hiding this comment.
Moved deliberately; I'm not sure why but it feels right to have these elements near the top of the file, and leave the cache/buildscan related parts at the bottom.
bsideup
approved these changes
May 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to apply our dynamic approach for GitHub Actions jobs to the examples. This includes use of the remote Gradle cache so that we only run an optimal subset of the example jobs.
Two things irk me about this PR:
Extensive duplication between
ci.ymlandci-examples.yml. I considered trying to set up a matrix arrangement to avoid this, but I suspect it would become an even more complicated arrangement. We've probably already used up all our 'cleverness budget' with the existing dynamic job discovery. I think that on balance duplicating lots of the workflow file may be inelegant but is at least much clearer.I could not find a way to share the Gradle cache configuration between the
./settings.gradleand./examples/settings.gradle. Extracting this to a custom script plugin failed: even a working setup would break when--scanwas enabled, and I've not yet had the energy to investigate why.I think that, unless I've missed something very obvious, I'd like to proceed with the PR despite both of these annoyances. Happy to hear feedback to the contrary though :)