Skip to content

Exclude multi-module module-info.class from shaded JAR#2588

Merged
rnorth merged 1 commit intomasterfrom
fix-shaded-jar
Apr 18, 2020
Merged

Exclude multi-module module-info.class from shaded JAR#2588
rnorth merged 1 commit intomasterfrom
fix-shaded-jar

Conversation

@rnorth
Copy link
Copy Markdown
Member

@rnorth rnorth commented Apr 18, 2020

Similar to 8dede04

@rnorth rnorth requested review from bsideup and kiview as code owners April 18, 2020 12:12
@rnorth
Copy link
Copy Markdown
Member Author

rnorth commented Apr 18, 2020

I've excluded the module-info.class which was leaking into the JAR via the META-INF/versions (multi module JAR) route.

I chose not to exclude the entire versions directory, because it would probably be valid for non-module-info classes to end up being shaded there at some point, and excluding those classes entirely may be bad news.

There's nothing yet in there, though. We'll also need to update the test if and when that changes.

@rnorth rnorth merged commit e7230c2 into master Apr 18, 2020
@rnorth rnorth deleted the fix-shaded-jar branch April 18, 2020 13:23
@rnorth rnorth added this to the next milestone Apr 18, 2020
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants