Fix localstack cloudwatchlogs service#2316
Merged
rnorth merged 3 commits intotestcontainers:masterfrom Feb 5, 2020
Merged
Conversation
MariuszCwikla
requested review from
bsideup,
kiview and
rnorth
as code owners
rnorth
approved these changes
Feb 5, 2020
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Thank you @MariuszCwikla, I wasn't aware the name differed. Thanks for taking the time to fix. Will merge.
rnorth
changed the title
artjomka
pushed a commit
to artjomka/testcontainers-java
that referenced
this pull request
Feb 28, 2020
Member
|
Released in 1.13.0! Thanks for the contribution @MariuszCwikla 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this pull request fixes cloudwatch logs with localstack.
According to https://hub.docker.com/r/localstack/localstack/ (search for "service names of the AWS CLI")
service name for cloudwatch logs should be "logs", not "cloudwatchlogs".
Please note: I've implemented two tests. One of them is
@Ignoreddue to localstack/localstack#1434 (createLogGroupworks fine, but fails indescribeLogGroups)