Vault: add a fluent API for configuring Vault's logging level#2231
Merged
rnorth merged 1 commit intotestcontainers:masterfrom Oct 30, 2020
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
rnorth
approved these changes
Oct 14, 2020
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Sorry for taking a long time to review. I think this is fine. A test would be nice to have, but ultimately the implementation is so simple that I think the difficulty of testing would outweigh.
rnorth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the logging level of Vault is useful while debugging Vault Container.
Added a fluent-API to allow easier/safer setting of logging level.