Conversation
we were skipping first 8 bytes in case of a RAW stream
rnorth
approved these changes
Dec 7, 2019
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
This makes sense to me, and I can see that it fixes a possible bug in the raw stream handling.
Are there any bug repro tests we could introduce? As we're backporting to docker-java, perhaps the test would belongs there anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were skipping first 8 bytes in case of a RAW stream