idiomatize test container configuration in kotlin example#1964
Merged
kiview merged 2 commits intotestcontainers:masterfrom Mar 4, 2020
Merged
idiomatize test container configuration in kotlin example#1964kiview merged 2 commits intotestcontainers:masterfrom
kiview merged 2 commits intotestcontainers:masterfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
Author
|
No one? |
Member
|
@alex0ptr |
kiview
approved these changes
Mar 4, 2020
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…iners#1964) Co-authored-by: Kevin Wittek <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example for Kotlin is more complex than necessary and does not use idiomatic Kotlin features to solve the issue of chaining.
Using a scoping function the example is more readable and clear for Kotlin natives.