Add support for DockerClient event streaming#1886
Merged
rnorth merged 6 commits intotestcontainers:masterfrom Oct 1, 2019
Merged
Add support for DockerClient event streaming#1886rnorth merged 6 commits intotestcontainers:masterfrom
rnorth merged 6 commits intotestcontainers:masterfrom
Conversation
mitchjust
force-pushed
the
event-streaming
branch
from
529d060 to
5769847
Compare
bsideup
reviewed
Sep 18, 2019
core/src/test/java/org/testcontainers/dockerclient/EventStreamTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Sep 18, 2019
core/src/test/java/org/testcontainers/dockerclient/EventStreamTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Sep 18, 2019
core/src/test/java/org/testcontainers/dockerclient/EventStreamTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Sep 18, 2019
core/src/test/java/org/testcontainers/dockerclient/EventStreamTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Sep 18, 2019
core/src/test/java/org/testcontainers/dockerclient/EventStreamTest.java
Outdated
Show resolved
Hide resolved
mitchjust
force-pushed
the
event-streaming
branch
from
5769847 to
ac0c531
Compare
Contributor
Author
|
Thanks for the review @bsideup, I think I've addressed all of your comments |
kiview
approved these changes
Sep 24, 2019
rnorth
approved these changes
Oct 1, 2019
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Nice - thank you for contributing @mitchjust, and thanks for the read-on-close fix @bsideup 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that event streaming from the DockerClient as specified in the docker-java wiki (https://github.com/docker-java/docker-java/wiki#handle-events) doesn't work, as get(TypeReference typeReference, ResultCallback resultCallback) is not implemented in OkHttpInvocationBuilder.java