Automatically set SHM for selenium container, and allow SHM size to be configured#1751
Automatically set SHM for selenium container, and allow SHM size to be configured#1751rnorth merged 6 commits intotestcontainers:masterfrom
Conversation
modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java
Outdated
Show resolved
Hide resolved
bsideup
left a comment
bsideup
left a comment
There was a problem hiding this comment.
Could you please add tests that verify both behaviors? The "mounted shm" one can simply assert the result of getContainerInfo
modules/selenium/src/test/java/org/testcontainers/junit/BrowserWebDriverContainerTest.java
Outdated
Show resolved
Hide resolved
| ) { | ||
| webDriverContainer.start(); | ||
| assertEquals("Shared memory size is configured", 512 * FileUtils.ONE_MB, webDriverContainer.getShmSize()); | ||
| assertEquals("No mounts present", webDriverContainer.getContainerInfo().getMounts().size(), 0); |
There was a problem hiding this comment.
please check that there are no shm mounts, not just any, so that if we add some volumes in future, it won't break the test (same in createContainerWithShmVolume)
There was a problem hiding this comment.
FTR this one was only partially resolved. @glefloch please do not resolve other's comments, let the author resolve it when he thinks it is so
There was a problem hiding this comment.
Sorry @bsideup, I will open another pull request with this fix. I thought it was only for this test...
modules/selenium/src/test/java/org/testcontainers/junit/BrowserWebDriverContainerTest.java
Outdated
Show resolved
Hide resolved
|
@rnorth I left a couple of comments about the tests, good to go once fixed :) |
rnorth
changed the title
3 participants
close #1670 by setting the shared memory to 2Go.