Fix/map execption semantically correct#1566
Fix/map execption semantically correct#1566HaMatthias wants to merge 22 commits intotestcontainers:masterfrom HaMatthias:fix/Map-execption-semantically-correct
Conversation
|
@HaMatthias could you please update your PR? It is based on a merged branch and has some conflicts now since the branch was merged |
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Some super trivial wording tweaks
core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
Outdated
Show resolved
Hide resolved
|
@HaMatthias please could you have a look at my suggested changes? |
|
Sounds good. PR incoming |
HaMatthias
left a comment
HaMatthias
left a comment
There was a problem hiding this comment.
Wording looks good.
|
@HaMatthias I think you may have forgotten to push! Please could you check? |
|
@HaMatthias I see you've merged master back into your branch, but it still doesn't look like you've pushed any changes since my review. It looks like you've resolved the comments without changes:
Please could you push, if you've made changes? Also, please allow us to push the resolve button after re-reviewing. |
…Container.java Co-Authored-By: Richard North <[email protected]>
…Container.java Co-Authored-By: Richard North <[email protected]>
…Container.java Co-Authored-By: Richard North <[email protected]>
…Container.java Co-Authored-By: Richard North <[email protected]>
core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
Outdated
Show resolved
Hide resolved
…Container.java Co-Authored-By: Richard North <[email protected]>
|
I do not know were I can allow you |
|
🤦♂ sorry, it looks like my suggested change had an unclosed quote 😱 |
|
I need to close this PR to replace it with a new, fixed branch. |
|
Thank you for the contribution @HaMatthias - finally merged in #2154! |
3 participants
Hi, alongside with the docker-compose pull request #1528 I did an exception handling for requesting non existing port mappings.
I am very new to programming so feel free for hints/mistakes.
Please consider the other PR as well.