chore: reduce concurrent builds#702
Merged
mdelapenya merged 2 commits intotestcontainers:mainfrom Dec 19, 2022
Merged
Conversation
It will avoid multiple pushes to have concurrent builds, aborting running builds in the followins scenarios: - for PRs, a new commit will abort running builds for the workflow - for branches, because it will use the SHA commit as discriminator, a new commit won't abort the running builds
HofmeisterAn
approved these changes
Dec 19, 2022
Member
|
Sidenote: In this PR, we see the drawback of duplicating the pipeline config across modules. |
kiview
approved these changes
Dec 19, 2022
Member
Author
Indeed, it would represent how we would suffer having a multi-repo, so we have to update just one repository with the new changes. |
mdelapenya
referenced
this pull request
in mdelapenya/testcontainers-go
Dec 21, 2022
* main: (79 commits) chore: reduce concurrent builds (#702) chore: add mysql example (#700) chore(deps): bump google.golang.org/api from 0.104.0 to 0.105.0 (#699) chore(deps): bump google.golang.org/api in /examples/firestore (#683) chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (#688) chore(deps): bump google.golang.org/api in /examples/pubsub (#685) chore(deps): bump google.golang.org/api in /examples/spanner (#684) chore(deps): bump google.golang.org/grpc in /examples/firestore (#686) chore(deps): bump google.golang.org/api in /examples/bigtable (#680) chore(deps): bump google.golang.org/api in /examples/datastore (#678) chore(deps): bump golang.org/x/text from 0.3.7 to 0.5.0 (#660) chore(deps): bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (#677) chore: postgres example (#674) Add bigtable example (#676) chore(deps): bump github.com/containerd/containerd from 1.6.10 to 1.6.12 (#675) chore: run go mod tidy in examples (#672) Improve datastore, firestore, pubsub and spanner tests (#670) chore: group dependabot updates (#668) chore: update mkdocs format to go-yaml v3 (#667) chore: generate dependabot configs for examples (#654) ...
mdelapenya
added a commit
to slsyy/testcontainers-go
that referenced
this pull request
Dec 21, 2022
* main: (335 commits) chore: reduce concurrent builds (testcontainers#702) chore: add mysql example (testcontainers#700) chore(deps): bump google.golang.org/api from 0.104.0 to 0.105.0 (testcontainers#699) chore(deps): bump google.golang.org/api in /examples/firestore (testcontainers#683) chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#688) chore(deps): bump google.golang.org/api in /examples/pubsub (testcontainers#685) chore(deps): bump google.golang.org/api in /examples/spanner (testcontainers#684) chore(deps): bump google.golang.org/grpc in /examples/firestore (testcontainers#686) chore(deps): bump google.golang.org/api in /examples/bigtable (testcontainers#680) chore(deps): bump google.golang.org/api in /examples/datastore (testcontainers#678) chore(deps): bump golang.org/x/text from 0.3.7 to 0.5.0 (testcontainers#660) chore(deps): bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (testcontainers#677) chore: postgres example (testcontainers#674) Add bigtable example (testcontainers#676) chore(deps): bump github.com/containerd/containerd from 1.6.10 to 1.6.12 (testcontainers#675) chore: run go mod tidy in examples (testcontainers#672) Improve datastore, firestore, pubsub and spanner tests (testcontainers#670) chore: group dependabot updates (testcontainers#668) chore: update mkdocs format to go-yaml v3 (testcontainers#667) chore: generate dependabot configs for examples (testcontainers#654) ...
mdelapenya
referenced
this pull request
in mdelapenya/testcontainers-go
Jan 4, 2023
* main: (44 commits) feat: support passing registry credentials to the reaper (#647) fix: close response body in http strategy (#718) chore: move e2e module to postgres example module (#717) chore: bump containerd transitive dep in examples (#715) chore(deps): bump github.com/containerd/containerd from 1.6.12 to 1.6.14 (#703) chore(deps): bump github.com/compose-spec/compose-go in /modules/compose (#710) chore: bump testcontainers-go to 0.17.0 in examples (#714) chore(deps): bump github.com/docker/compose/v2 in /modules/compose (#711) chore: support running MySQL compose in ARM (#712) chore: simplify compose replace directives (#713) chore: add compose module to dependabot (#709) chore: move compose code to a separate module (#650) docs: refine onboarding process with quickstart guide (#706) chore: move redis-specific tests to the example module (#701) chore: bump transitive dependencies (#527) chore: reduce concurrent builds (#702) chore: add mysql example (#700) chore(deps): bump google.golang.org/api from 0.104.0 to 0.105.0 (#699) chore(deps): bump google.golang.org/api in /examples/firestore (#683) chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (#688) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It will avoid multiple pushes to have concurrent builds, aborting running builds in the followins scenarios:
Why is it important?
Taking a look at https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration, it seems there is a max number of concurrent builds per organization.
@kiview, we should consider this for any project spanning multiple builds (per lang, per module, per OS...).
Related issues