Skip to content

feat: Auth config for build images#602

Merged
mdelapenya merged 10 commits intotestcontainers:mainfrom
paulozenida:feature/auth-config-for-build-images
Nov 3, 2022
Merged

feat: Auth config for build images#602
mdelapenya merged 10 commits intotestcontainers:mainfrom
paulozenida:feature/auth-config-for-build-images

Conversation

@paulozenida
Copy link
Copy Markdown
Contributor

@paulozenida paulozenida commented Oct 31, 2022

This PR allows for the feature reported in the following issue: #601

@paulozenida paulozenida requested a review from a team as a code owner October 31, 2022 13:34
mdelapenya
mdelapenya reviewed Nov 2, 2022
View reviewed changes
mdelapenya
mdelapenya reviewed Nov 2, 2022
View reviewed changes
mdelapenya
mdelapenya reviewed Nov 2, 2022
View reviewed changes
@mdelapenya
Copy link
Copy Markdown
Member

mdelapenya commented Nov 3, 2022 •
edited
Loading

@paulozenida I saw the PR is failing the TestDockerCreateContainerWithDirs test because here

testcontainers-go/docker_test.go

Line 2566 in dd2248a

srcBytes, err := ioutil.ReadFile(filepath.Join(hostFilePath, srcFile.Name()))
the existing code is not controlling that a directory could exist under testresources. At the moment you added the registry dirs, that test fails, and I think it should be fixed in this PR.

I'd say that simply checking the current srcFile is not a directory, and then read it would be enough. Could you include it in this PR?

Thanks!

@paulozenida
Copy link
Copy Markdown
Contributor Author

paulozenida commented Nov 3, 2022

Sure. I've just included the suggested change.

@mdelapenya mdelapenya added the enhancement New feature or request label Nov 3, 2022
@mdelapenya mdelapenya self-assigned this Nov 3, 2022
@mdelapenya
Copy link
Copy Markdown
Member

mdelapenya commented Nov 3, 2022

Sure. I've just included the suggested change.

To avoid causing you more trouble in the pingpong review on failed tests, I added a commit with the same fix in another test: TestTarDir. Hopefully this will PASS 🤞

mdelapenya
mdelapenya approved these changes Nov 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @paulozenida in this PR!

I'm updating the branch with current main. Once the CI passes, I'll merge it 🚀

BTW; the project is missing the same mechanism for pulling images from private registries in other places. As you already contributed this part for the FromDockerfile part, I wonder if you would be interested in contributing the others, such as the Docker Compose code. I can be of any help assisting you identifying where to add it. Please let me know if you'd like to participate.

@mdelapenya mdelapenya merged commit cc9c80d into testcontainers:main Nov 3, 2022
@paulozenida paulozenida deleted the feature/auth-config-for-build-images branch November 3, 2022 13:46
@paulozenida
Copy link
Copy Markdown
Contributor Author

paulozenida commented Nov 3, 2022

Great job @paulozenida in this PR!

I'm updating the branch with current main. Once the CI passes, I'll merge it 🚀

BTW; the project is missing the same mechanism for pulling images from private registries in other places. As you already contributed this part for the FromDockerfile part, I wonder if you would be interested in contributing the others, such as the Docker Compose code. I can be of any help assisting you identifying where to add it. Please let me know if you'd like to participate.

Thank @mdelapenya.

I'm not sure I'll be able to do that right now but if you open an issue explaining the details, I might try to get to it next week or try to find someone in my organisation/team that can try to do so.

@mdelapenya mdelapenya mentioned this pull request Nov 3, 2022
Closed
mdelapenya referenced this pull request in mdelapenya/testcontainers-go Nov 9, 2022
@mdelapenya
Merge branch 'main' into examples
ed0121e 
* main:
  docs: networking basics (#612)
  docs: wording in project name (#610)
  feat: Auth config for build images (#602)
  chore: sync governance files (#608)
@mdelapenya mdelapenya mentioned this pull request Dec 5, 2022
Closed
@mdelapenya mdelapenya mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulozenida @mdelapenya