fix: check if the container request is for the reaper#574
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Oct 21, 2022
Merged
fix: check if the container request is for the reaper#574mdelapenya merged 1 commit intotestcontainers:mainfrom
mdelapenya merged 1 commit intotestcontainers:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
===========================================
- Coverage 32.84% 15.40% -17.44%
===========================================
Files 13 13
Lines 1757 1759 +2
===========================================
- Hits 577 271 -306
- Misses 1092 1442 +350
+ Partials 88 46 -42
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eddumelendez
approved these changes
Oct 21, 2022
mdelapenya
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It checks if the container request of the current container is for a reaper before creating a reaper for the container.
Therefore, the banner for the reaper must not be displayed.
Why is it important?
When a reaper is created, it always skips the reaper for itself, so we must check if the request is for a reaper, and this is achieved comparing the reaper image and the image of the request
Related issues