fix: pass docker context key when reusing a container#550
Merged
mdelapenya merged 7 commits intotestcontainers:mainfrom Oct 19, 2022
Merged
fix: pass docker context key when reusing a container#550mdelapenya merged 7 commits intotestcontainers:mainfrom
mdelapenya merged 7 commits intotestcontainers:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 15.08% 15.08%
=======================================
Files 13 13
Lines 1757 1757
=======================================
Hits 265 265
Misses 1446 1446
Partials 46 46
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* chore: create network's session ID for reaper, only * chore: include reaper-specific labels to the reaper container * feat: initialise sessionID just once * chore: do not expose the sessionID function * fix: update reaper tests
* main: feat: add sessionID HTTP Header to the Docker client setup (#570)
mdelapenya
added
type/bug
and removed
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It passes the docker_host key to the reaper creation when using the ReuseOrCreate container function, so that the reaper is able to extract the Docker host.
Reuse is available as a field in the GenericContainerRequest struct.
At the same time, the PR is adding tests to demonstrate the new behavior
Why is it important?
Consistency. Any other call to NewReaper is passing the host from the provider. Before these changes it was not passed, so the reaper directly returns
/var/run/docker.sockwhen theTESTCONTAINERS_DOCKER_SOCKET_OVERRIDEenvironment variable is not set.