Skip to content

add containerised docker compose and tests#463

Closed
mazitovt wants to merge 1 commit intotestcontainers:mainfrom
mazitovt:feature/containerised_compose
Closed

add containerised docker compose and tests#463
mazitovt wants to merge 1 commit intotestcontainers:mainfrom
mazitovt:feature/containerised_compose

Conversation

@mazitovt
Copy link
Copy Markdown

Feature for Issue #425

Added ContainerisedDockerCompose struct with embedded LocalDockerCompose and override all DockerCompose methods. Added two functions executeInContainer and executeComposeInContainer, that work with docker/compose container.

@mazitovt
Copy link
Copy Markdown
Author

@mdelapenya, hi. You've mentioned my PR, but never gave a feedback. Can you please review it?

@mdelapenya
Copy link
Copy Markdown
Member

@mdelapenya, hi. You've mentioned my PR, but never gave a feedback. Can you please review it?

Hi @mazitovt this compose has different "rivals" :)

I pinged you in the issue just in case you want to participate in it to design what compose APIs we want to have

Again, sorry if I should have been more responsive in this PR 🙏

@mdelapenya mdelapenya added the compose Docker Compose. label Oct 6, 2022
@mdelapenya
Copy link
Copy Markdown
Member

Hi @mazitovt we have merged #476, which adds native support for docker compose, deprecating the local docker compose implementation. I'm not sure if we'd need a dockerised one now that we can run it natively, but wanted to check with you first before closing this issue.

@mazitovt
Copy link
Copy Markdown
Author

@mdelapenya ok. I close my PR.

@mazitovt mazitovt closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compose Docker Compose.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants