add containerised docker compose and tests#463
Closed
mazitovt wants to merge 1 commit intotestcontainers:mainfrom
Closed
add containerised docker compose and tests#463mazitovt wants to merge 1 commit intotestcontainers:mainfrom
mazitovt wants to merge 1 commit intotestcontainers:mainfrom
Conversation
This was referenced Jun 15, 2022
Author
|
@mdelapenya, hi. You've mentioned my PR, but never gave a feedback. Can you please review it? |
Member
Hi @mazitovt this compose has different "rivals" :)
I pinged you in the issue just in case you want to participate in it to design what compose APIs we want to have Again, sorry if I should have been more responsive in this PR 🙏 |
Member
Author
|
@mdelapenya ok. I close my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature for Issue #425
Added
ContainerisedDockerComposestruct with embeddedLocalDockerComposeand override allDockerComposemethods. Added two functionsexecuteInContainerandexecuteComposeInContainer, that work with docker/compose container.