Codecov Report

Merging #407 (bd4c1b6) into master (c0c2f90) will increase coverage by 0.26%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   65.05%   65.32%   +0.26%     
==========================================
  Files          19       19              
  Lines        1159     1165       +6     
==========================================
+ Hits          754      761       +7     
+ Misses        301      300       -1     
  Partials      104      104              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c2f90...bd4c1b6. Read the comment docs.

Can't wait for this feature, I'm using lima on a M1 macbook, the default docker sock won't work out of the box so this would safe a lot of work and time helping others with the setup

Thanks for this contribution @mniak! It LGTM

I'm postponing the merge until I get a deeper understanding of #414

can't this ship without the rest of #414?

@mdelapenya it seems #414 might take some time to have all the edge cases covered. As this is a relatively small change with manageable side effects do you still think this change should wait?

From my point of view there is a lot of value in this change already. Is there any particular info you need to reconsider?

@mdelapenya it seems #414 might take some time to have all the edge cases covered. As this is a relatively small change with manageable side effects do you still think this change should wait?

From my point of view there is a lot of value in this change already. Is there any particular info you need to reconsider?

I second that. This small feature will help with multiple non native docker backends. With lima serving my docker instances I can't use testcontainers until this is implemented.

Thanks all for the positive feedback in this PR. I think it's safe to merge it as is, and delegate the full podman compatibility to #414

@baez90 if you agree I'm merging this one after your 👍

Sure, makes sense I think and rebasing this should be straightforward

Merged, thanks!

Can I already use this feature?

It's not released yet but you can use it if you update your dependency to latest main branch if you really want