deps: update go version from 1.22.0 to 1.23.0#2985
deps: update go version from 1.22.0 to 1.23.0#2985mdelapenya merged 1 commit intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmorel-35
force-pushed
the
go-1.23
branch
2 times, most recently
from
a15ab57 to
12b5e47
Compare
|
I think the GH worker is caching 1.x as 1.23, and it could take days/week until the new version is cached 🤔 I think it may be time to be explicit in the upper version and use 1.24.x instead of 1.x, as in the end, we are going to update both values altogether. Thoughts?
|
|
Would purging the Github cache in testcountainers-go settings help with that ? |
|
Mmm there are cases where it's not even cached: https://github.com/testcontainers/testcontainers-go/actions/runs/13368415985/job/37331548975#step:4:21
|
mmorel-35
force-pushed
the
go-1.23
branch
3 times, most recently
from
5e42aa4 to
b82098e
Compare
|
Why merge instead of rebase ? |
|
If the final state of the PR is going to be squashed, what's the difference? I personally don't like push-forces in shared branches, probably that's why I think merges are better, but I'd like to understand your point of view to learn from it too |
Signed-off-by: Matthieu MOREL <[email protected]>
I like having a clean git history and once a merge commit happen on a branch I'm working on I can't squash them anymore but the maintainer of the original project can throught github. Several project don't necessary do by choice or by mistake. If you then need to cherry-pick a functionality (one expected commit) from a branch to another, that can become a real nightmare. |
mdelapenya
added
chore
For similar reasons on a clean git history, but for reviews, anytime a push-force is done, we maintainers have to create a new mental model for the state of the code, checking if something already reviewed changed. That's why I prefer updating the branch from the UI with a merge (or locally with Of course, this is a process that depends on each project. I do like this way because it allows me to focus on the incoming deltas. |
mdelapenya
removed
the
chore
* main: (54 commits) deps: update go version from 1.22.0 to 1.23.0 (testcontainers#2985) feat(redpanda): add bootstrap user account option (testcontainers#2975) chore(ollama): bump default version to 0.5.7 (testcontainers#2966) feat!: log package for consistent output (testcontainers#2979) docs: remove duplicated options in the customisers lists (testcontainers#2989) chore: exclude "modules/k6" from the build (testcontainers#2987) chore: enable var-naming from revive (private vars only) (testcontainers#2978) chore(deps): bump actions/checkout from 4.1.7 to 4.2.2 (testcontainers#2971) chore(deps): bump release-drafter/release-drafter from 6.0.0 to 6.1.0 (testcontainers#2970) chore!: remove variadic arguments from nats ConnectionString (testcontainers#2967) fix(ci): use same condition for sonar steps (testcontainers#2974) fix: return unique modified modules (testcontainers#2973) chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.3.0 (testcontainers#2969) chore(ci): run lint in a separate build before running the tests (testcontainers#2876) fix(deps): update to github.com/shirou/gopsutil/v4 (testcontainers#2964) fix(valkey): fix port race (testcontainers#2962) chore(deps): bump golang.org/x/net in /modules/pinecone (testcontainers#2963) chore(deps): bump golang.org/x/net from 0.26.0 to 0.33.0 (testcontainers#2961) deps(fix): include modulegen templates dir in dependabot updates (testcontainers#2956) chore(deps): bump docker/setup-docker-action from 4.0.0 to 4.1.0 (testcontainers#2959) ...
* main: (34 commits) deps: update go version from 1.22.0 to 1.23.0 (testcontainers#2985) feat(redpanda): add bootstrap user account option (testcontainers#2975) chore(ollama): bump default version to 0.5.7 (testcontainers#2966) feat!: log package for consistent output (testcontainers#2979) docs: remove duplicated options in the customisers lists (testcontainers#2989) chore: exclude "modules/k6" from the build (testcontainers#2987) chore: enable var-naming from revive (private vars only) (testcontainers#2978) chore(deps): bump actions/checkout from 4.1.7 to 4.2.2 (testcontainers#2971) chore(deps): bump release-drafter/release-drafter from 6.0.0 to 6.1.0 (testcontainers#2970) chore!: remove variadic arguments from nats ConnectionString (testcontainers#2967) fix(ci): use same condition for sonar steps (testcontainers#2974) fix: return unique modified modules (testcontainers#2973) chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.3.0 (testcontainers#2969) chore(ci): run lint in a separate build before running the tests (testcontainers#2876) fix(deps): update to github.com/shirou/gopsutil/v4 (testcontainers#2964) fix(valkey): fix port race (testcontainers#2962) chore(deps): bump golang.org/x/net in /modules/pinecone (testcontainers#2963) chore(deps): bump golang.org/x/net from 0.26.0 to 0.33.0 (testcontainers#2961) deps(fix): include modulegen templates dir in dependabot updates (testcontainers#2956) chore(deps): bump docker/setup-docker-action from 4.0.0 to 4.1.0 (testcontainers#2959) ...
2 participants
What does this PR do?
Go 1.24.0 has been released on since 11 February 2025
This update Go version from 1.22.0 to 1.23.0