feat(redpanda): add bootstrap user account option#2975
Merged
mdelapenya merged 18 commits intotestcontainers:mainfrom Feb 20, 2025
Merged
feat(redpanda): add bootstrap user account option#2975mdelapenya merged 18 commits intotestcontainers:mainfrom
mdelapenya merged 18 commits intotestcontainers:mainfrom
Conversation
feat(redpanda): rework the admin api auth feat(redpanda): rework the admin api auth
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Feb 6, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
Hi @bojand thanks for submitting this PR, I left a few minor comments.
What we miss here is the update of the docs site: docs/modules/redpanda.md. Let's add there the docs for the new functional option. Please use the existing ones as reference.
Yeah, the Go docs are already here in place, but we maintain a separate docs site where we can be more expressive.
added 2 commits
February 7, 2025 11:15
…PIAuthentication. Address PR feedback to cleanup tests
Contributor
Author
|
Hello, thanks for the PR feedback. I think I addressed the feedback and cleaned up the rests of the tests in Redpanda module. |
mdelapenya
reviewed
Feb 10, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
I added some suggestions regarding the subtests names. They are indeed cosmetic changes, but they enable debugging those tests with easy when they fail, by just copying the name and running them in isolation.
We are moving to that pattern for new tests, and converting the existing ones containing spaces when touching them.
Other than that, LGTM
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Contributor
Author
|
Thank you for the review and suggestions. I think I addressed them. |
mdelapenya
added
the
feature
mdelapenya
reviewed
Feb 10, 2025
stevenh
reviewed
Feb 10, 2025
added 4 commits
February 10, 2025 12:13
mdelapenya
previously approved these changes
Feb 20, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM; I'm adding some suggestions regarding test names including whitespaces, but I'm gonna commit them on your behalf to not delay this more.
Thanks for your contribution!
mdelapenya
approved these changes
Feb 20, 2025
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Feb 20, 2025
* main: (54 commits) deps: update go version from 1.22.0 to 1.23.0 (testcontainers#2985) feat(redpanda): add bootstrap user account option (testcontainers#2975) chore(ollama): bump default version to 0.5.7 (testcontainers#2966) feat!: log package for consistent output (testcontainers#2979) docs: remove duplicated options in the customisers lists (testcontainers#2989) chore: exclude "modules/k6" from the build (testcontainers#2987) chore: enable var-naming from revive (private vars only) (testcontainers#2978) chore(deps): bump actions/checkout from 4.1.7 to 4.2.2 (testcontainers#2971) chore(deps): bump release-drafter/release-drafter from 6.0.0 to 6.1.0 (testcontainers#2970) chore!: remove variadic arguments from nats ConnectionString (testcontainers#2967) fix(ci): use same condition for sonar steps (testcontainers#2974) fix: return unique modified modules (testcontainers#2973) chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.3.0 (testcontainers#2969) chore(ci): run lint in a separate build before running the tests (testcontainers#2876) fix(deps): update to github.com/shirou/gopsutil/v4 (testcontainers#2964) fix(valkey): fix port race (testcontainers#2962) chore(deps): bump golang.org/x/net in /modules/pinecone (testcontainers#2963) chore(deps): bump golang.org/x/net from 0.26.0 to 0.33.0 (testcontainers#2961) deps(fix): include modulegen templates dir in dependabot updates (testcontainers#2956) chore(deps): bump docker/setup-docker-action from 4.0.0 to 4.1.0 (testcontainers#2959) ...
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Feb 20, 2025
* main: (34 commits) deps: update go version from 1.22.0 to 1.23.0 (testcontainers#2985) feat(redpanda): add bootstrap user account option (testcontainers#2975) chore(ollama): bump default version to 0.5.7 (testcontainers#2966) feat!: log package for consistent output (testcontainers#2979) docs: remove duplicated options in the customisers lists (testcontainers#2989) chore: exclude "modules/k6" from the build (testcontainers#2987) chore: enable var-naming from revive (private vars only) (testcontainers#2978) chore(deps): bump actions/checkout from 4.1.7 to 4.2.2 (testcontainers#2971) chore(deps): bump release-drafter/release-drafter from 6.0.0 to 6.1.0 (testcontainers#2970) chore!: remove variadic arguments from nats ConnectionString (testcontainers#2967) fix(ci): use same condition for sonar steps (testcontainers#2974) fix: return unique modified modules (testcontainers#2973) chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.3.0 (testcontainers#2969) chore(ci): run lint in a separate build before running the tests (testcontainers#2876) fix(deps): update to github.com/shirou/gopsutil/v4 (testcontainers#2964) fix(valkey): fix port race (testcontainers#2962) chore(deps): bump golang.org/x/net in /modules/pinecone (testcontainers#2963) chore(deps): bump golang.org/x/net from 0.26.0 to 0.33.0 (testcontainers#2961) deps(fix): include modulegen templates dir in dependabot updates (testcontainers#2956) chore(deps): bump docker/setup-docker-action from 4.0.0 to 4.1.0 (testcontainers#2959) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an option to have a bootstrap user account when starting the container.
See https://docs.redpanda.com/current/deploy/deployment-option/self-hosted/manual/production/production-deployment/#bootstrap-a-user-account
Why is it important?
Without this option and capability it is not possible to successfully start the Redpanda testcontainers module with Admin API authentication on (
admin_api_require_authconfig set totrue).