Skip to content

chore: fix typos#2940

Merged
mdelapenya merged 2 commits intotestcontainers:mainfrom
NathanBaulch:typos
Jan 14, 2025
Merged

chore: fix typos#2940
mdelapenya merged 2 commits intotestcontainers:mainfrom
NathanBaulch:typos

Conversation

@NathanBaulch
Copy link
Copy Markdown
Contributor

@NathanBaulch NathanBaulch commented Jan 10, 2025

What does this PR do?

Fixes a bunch of typos.

Why is it important?

Improves readability and professionalism.

The top typos are:

  • endpoing
  • containerr
  • detault
  • loggin
  • suplied
  • aso
  • credencials
  • dokerfile
  • enpoint
  • serices
  • weavite
  • inititial
  • applcation
  • confif
  • consistenly
  • defering
  • entires
  • entiry
  • prepate
  • referece
  • secific
  • thre
  • underliying
  • unlinke

@NathanBaulch NathanBaulch requested a review from a team as a code owner January 10, 2025 21:44
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 10, 2025 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67861f7bb553eac71dff4aab
😎 Deploy Preview https://deploy-preview-2940--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stevenh
stevenh requested changes Jan 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just a few comments to get this in

@NathanBaulch NathanBaulch mentioned this pull request Jan 13, 2025
Merged
@NathanBaulch NathanBaulch changed the title fix: typos fix!: typos Jan 13, 2025
@NathanBaulch NathanBaulch changed the title fix!: typos fix: typos Jan 14, 2025
@NathanBaulch NathanBaulch mentioned this pull request Jan 14, 2025
Merged
mdelapenya
mdelapenya approved these changes Jan 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this 🙇

I'm changing the PR title to chore: fix typos as it's not changing the existing behaviour, but fixing typos both in code and the docs. Therefore the PR will land in the Housekeeping section in the release notes.

@mdelapenya
Copy link
Copy Markdown
Member

mdelapenya commented Jan 14, 2025

BTW @NathanBaulch did you use an automated tool to find the typos? If so, I'd like to use it as part of the lint phase.

@NathanBaulch
Copy link
Copy Markdown
Contributor Author

NathanBaulch commented Jan 14, 2025

BTW @NathanBaulch did you use an automated tool to find the typos? If so, I'd like to use it as part of the lint phase.

I used a combination of https://github.com/crate-ci/typos (automated) and the built-in IntelliJ language tools (manual).

@mdelapenya mdelapenya changed the title fix: typos chore: fix typos Jan 14, 2025
@mdelapenya mdelapenya self-assigned this Jan 14, 2025
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jan 14, 2025
@mdelapenya
Copy link
Copy Markdown
Member

mdelapenya commented Jan 14, 2025

I retriggered Netlify's build and created the deployment, although it did not update the GH checks. LGTM anyway

@mdelapenya mdelapenya merged commit 37ca2b4 into testcontainers:main Jan 14, 2025
@NathanBaulch NathanBaulch deleted the typos branch January 14, 2025 10:32
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 3, 2025
@mdelapenya
Merge branch 'main' into run-lint-first
c23502c 
* main: (29 commits)
  deps(fix): include modulegen templates dir in dependabot updates (testcontainers#2956)
  chore(deps): bump docker/setup-docker-action from 4.0.0 to 4.1.0 (testcontainers#2959)
  feat: adds Pinecone module (testcontainers#2955)
  chore(deps): bump actions/setup-go from 5.1.0 to 5.3.0 (testcontainers#2957)
  chore(deps): bump actions/upload-artifact from 4.4.3 to 4.6.0 (testcontainers#2958)
  chore: enable unused-parameter from revive (testcontainers#2949)
  chore: enable use-any from revive (testcontainers#2948)
  bump golangci-lint to v1.63.4 (testcontainers#2950)
  chore: enable var-declaration from revive linter (testcontainers#2942)
  chore: enable context-as-argument from revive linter (testcontainers#2946)
  chore: enable early-return, indent-error-flow and superfluous-else from revive linter (testcontainers#2947)
  chore!: rename EnpointSettingsModifier to EndpointSettingsModifier
  fix(localstack): more reliable legacy tag detection (testcontainers#2936)
  chore: recover from panic in `SkipIfProviderIsNotHealthy` test helper function (testcontainers#2939)
  chore: fix typos (testcontainers#2940)
  deps(compose): bump compose (v2.32.2) and compose-go spec (v2.4.7) (testcontainers#2938)
  chore: prepare for next minor development cycle (0.36.0)
  chore: use new version (v0.35.0) in modules and examples
  feat(postgres): ssl for postgres (testcontainers#2473)
  feat(ollama): support calling the Ollama local process (testcontainers#2923)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenh stevenh stevenh requested changes

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels

chore Changes that do not impact the existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NathanBaulch @mdelapenya @stevenh