chore: recover from panic in SkipIfProviderIsNotHealthy test helper function#2939
Merged
mdelapenya merged 5 commits intotestcontainers:mainfrom Jan 14, 2025
Merged
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
youshibin
changed the title
SkipIfProviderIsNotHealthy test helper functionSkipIfProviderIsNotHealthy test helper function
mdelapenya
previously approved these changes
Jan 13, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, just suggesting fixing an existing typo.
Thanks!
mdelapenya
reviewed
Jan 13, 2025
Co-authored-by: Manuel de la Peña <[email protected]>
* Move t.Helper before defer
* Include value of r in skip statement
* Fix more typos
youshibin
force-pushed
the
jasonyunicorn/chore-2859
branch
from
aaa2733 to
cb5e5dc
Compare
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Feb 3, 2025
* main: (29 commits) deps(fix): include modulegen templates dir in dependabot updates (testcontainers#2956) chore(deps): bump docker/setup-docker-action from 4.0.0 to 4.1.0 (testcontainers#2959) feat: adds Pinecone module (testcontainers#2955) chore(deps): bump actions/setup-go from 5.1.0 to 5.3.0 (testcontainers#2957) chore(deps): bump actions/upload-artifact from 4.4.3 to 4.6.0 (testcontainers#2958) chore: enable unused-parameter from revive (testcontainers#2949) chore: enable use-any from revive (testcontainers#2948) bump golangci-lint to v1.63.4 (testcontainers#2950) chore: enable var-declaration from revive linter (testcontainers#2942) chore: enable context-as-argument from revive linter (testcontainers#2946) chore: enable early-return, indent-error-flow and superfluous-else from revive linter (testcontainers#2947) chore!: rename EnpointSettingsModifier to EndpointSettingsModifier fix(localstack): more reliable legacy tag detection (testcontainers#2936) chore: recover from panic in `SkipIfProviderIsNotHealthy` test helper function (testcontainers#2939) chore: fix typos (testcontainers#2940) deps(compose): bump compose (v2.32.2) and compose-go spec (v2.4.7) (testcontainers#2938) chore: prepare for next minor development cycle (0.36.0) chore: use new version (v0.35.0) in modules and examples feat(postgres): ssl for postgres (testcontainers#2473) feat(ollama): support calling the Ollama local process (testcontainers#2923) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Recovers from panic (in a
deferstatement) and skips the tests if necessary.Why is it important?
Attempting to skip tests on runners where Docker is not usable using
github.com/testcontainers/testcontainers-go.SkipIfProviderIsNotHealthyis still failing unconditionally.Related issues
Closes #2859
How to test this PR
Run the tests in CI/CD for
macos-latestrunners in GitHub Actions and observe if there any still any panics.Follow-ups