feat(nats): WithConfigFile - pass a configuration file to nats server#2905
Merged
mdelapenya merged 13 commits intotestcontainers:mainfrom Dec 5, 2024
Merged
feat(nats): WithConfigFile - pass a configuration file to nats server#2905mdelapenya merged 13 commits intotestcontainers:mainfrom
mdelapenya merged 13 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
requested changes
Dec 1, 2024
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Thanks for the PR, adding a config option is a good addition.
We're looking to use ContainerCustomizers where possible moving forward, looks like this would work for this case, so if we could make that switch it should simplify.
mdelapenya
reviewed
Dec 2, 2024
mdelapenya
added
the
feature
Add ConfigGile struct, which implements the interface.
mdelapenya
reviewed
Dec 2, 2024
mdelapenya
previously approved these changes
Dec 2, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, although I added two wording suggestions in the docs
mdelapenya
changed the title
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
reviewed
Dec 2, 2024
Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
reviewed
Dec 2, 2024
stevenh
requested changes
Dec 3, 2024
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Just a few tweaks to the language and test
Member
|
Merged, thanks for your work here 🙇 |
mdelapenya
added a commit
to mtellis2/testcontainers-go
that referenced
this pull request
Dec 11, 2024
* main: (234 commits) chore(ci): add Github labels based on PR title (testcontainers#2914) chore(gha): Use official setup-docker-action (testcontainers#2913) chore(ci): enforce conventional commits syntax in PR titles (testcontainers#2911) feat(nats): WithConfigFile - pass a configuration file to nats server (testcontainers#2905) chore: enable implicit default logger only in testing with -v (testcontainers#2877) fix: container binds syntax (testcontainers#2899) refactor(cockroachdb): to use request driven options (testcontainers#2883) chore(deps): bump actions/setup-go from 5.0.0 to 5.1.0 (testcontainers#2904) chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.0 (testcontainers#2903) chore(deps): bump test-summary/action from 2.3 to 2.4 (testcontainers#2902) feat(wait): strategy walk (testcontainers#2895) feat(wait): tls strategy (testcontainers#2896) docs: better contribution guidelines (testcontainers#2893) fix(influxdb): Respect custom waitStrategy (testcontainers#2845) fix: only upload to sonar on ubuntu-latest (testcontainers#2891) fix: build artifact name properly (testcontainers#2890) fix: do not run sonar upload when ryuk is disabled (testcontainers#2889) fix: update GH actions for uploading/downloading artifacts (testcontainers#2888) feat(ci): Enable master moby with rootless (testcontainers#2880) fix(redpanda): temporary file use ...
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Dec 13, 2024
* main: feat(gcloud)!: add support to seed data when using RunBigQueryContainer (testcontainers#2523) security(deps): bump golang.org/x/crypto from 0.28.0 to 0.31.0 (testcontainers#2916) chore(ci): add Github labels based on PR title (testcontainers#2914) chore(gha): Use official setup-docker-action (testcontainers#2913) chore(ci): enforce conventional commits syntax in PR titles (testcontainers#2911) feat(nats): WithConfigFile - pass a configuration file to nats server (testcontainers#2905) chore: enable implicit default logger only in testing with -v (testcontainers#2877) fix: container binds syntax (testcontainers#2899) refactor(cockroachdb): to use request driven options (testcontainers#2883)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Jan 8, 2025
* main: (103 commits) feat(postgres): ssl for postgres (testcontainers#2473) feat(ollama): support calling the Ollama local process (testcontainers#2923) chore(deps): bump jinja2 from 3.1.4 to 3.1.5 (testcontainers#2935) chore(deps): bump sonarsource/sonarcloud-github-action (testcontainers#2933) feat(termination)!: make container termination timeout configurable (testcontainers#2926) chore(deps): bump slackapi/slack-github-action from 1.26.0 to 2.0.0 (testcontainers#2934) chore(deps): bump github/codeql-action from 3.25.15 to 3.28.0 (testcontainers#2932) feat(wait): log sub match callback (testcontainers#2929) fix: Handle nil value in CleanupNetwork (testcontainers#2928) fix: avoid double lock in DockerProvider.DaemonHost() (testcontainers#2900) feat!: build log writer for container request (testcontainers#2925) feat(gcloud)!: add support to seed data when using RunBigQueryContainer (testcontainers#2523) security(deps): bump golang.org/x/crypto from 0.28.0 to 0.31.0 (testcontainers#2916) chore(ci): add Github labels based on PR title (testcontainers#2914) chore(gha): Use official setup-docker-action (testcontainers#2913) chore(ci): enforce conventional commits syntax in PR titles (testcontainers#2911) feat(nats): WithConfigFile - pass a configuration file to nats server (testcontainers#2905) chore: enable implicit default logger only in testing with -v (testcontainers#2877) fix: container binds syntax (testcontainers#2899) refactor(cockroachdb): to use request driven options (testcontainers#2883) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Nats server can be started with a custom configuration file.
Why is it important?
While a lot of options can be passed as a command line parameters, having an
ability to pass a custom configuration file helps a testing of more advanced
real world setups, like authn/authz.
Method
WithConfigFileis provided by other modules like postgresql. Thedifference is this version accepts
io.Reader, so configuration file does notneed to be a real file stored on a host. This simplifies a testing setup.
Related issues
N/A
How to test this PR
This PR adds a simple test starting the server with a custom authorization
token and shows a client without a correct one can't connect to the server,
while the one with a right one can.
As a final validation the logs of the container are checked for
Using configuration file: /etc/nats.conftext.