feat(ci): Test against the nightly master moby#2861
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Oct 31, 2024
Merged
feat(ci): Test against the nightly master moby#2861mdelapenya merged 1 commit intotestcontainers:mainfrom
mdelapenya merged 1 commit intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
previously approved these changes
Oct 30, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, this is great for testing! Much appreciated!
vvoland
force-pushed
the
moby-master
branch
2 times, most recently
from
e772aba to
8624042
Compare
Rootless is not supported yet. Signed-off-by: Paweł Gronowski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the Github actions workflow that ran the tests against a Docker Engine from the
testchannel of download.docker.com to get the nightly build off themasterbranch.Currently it uses the
crazy-max/ghaction-setup-docker@masteraction. We plan to move to to Docker org soon.It also adds the containerd integration to the test matrix.
Rootless is not supported yet.
Why is it important?
The
testchannel isn't updated that often as it requires us to run the whole release pipeline.With this change, testcontainers tests will be ran against the master branch of moby and test the containerd image store integration.