chore: use require instead of t.Fatal#2855
Merged
mdelapenya merged 3 commits intotestcontainers:mainfrom Oct 29, 2024
Merged
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmorel-35
force-pushed
the
testifier/require-error
branch
from
44d6717 to
be2a5d8
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifier/require-error
branch
from
be2a5d8 to
8424fb2
Compare
mdelapenya
reviewed
Oct 29, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
Just a few comments, regarding the usage of require.Zero, other than that, LGTM
Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added
chore
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Oct 29, 2024
* main: chore: use require instead of t.Fatal (testcontainers#2855)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This uses
requireinstead oft.FatalcallsWhy is it important?
This reduce the number of lines required to make an assertion.
It also make the assertion easier to understand.
Related issues