Skip to content

chore: enable usestdlibvars linter#2850

Merged
mdelapenya merged 3 commits intotestcontainers:mainfrom
mmorel-35:golangci-lint/usestdlibvars
Oct 28, 2024
Merged

chore: enable usestdlibvars linter#2850
mdelapenya merged 3 commits intotestcontainers:mainfrom
mmorel-35:golangci-lint/usestdlibvars

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

What does this PR do?

Setup usestdlibvars linter and apply it’s recommandations .

Why is it important?

usestdlibvars detect the possibility to use variables/constants from the Go standard library.

@mmorel-35 mmorel-35 requested a review from a team as a code owner October 26, 2024 11:24
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 26, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 2a0b002
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/671f6eeaf65abf0008bc2155
😎 Deploy Preview https://deploy-preview-2850--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Oct 28, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Oct 28, 2024
mdelapenya
mdelapenya previously approved these changes Oct 28, 2024
Copy link
Copy Markdown
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !!

@mdelapenya mdelapenya merged commit 9ed332a into testcontainers:main Oct 28, 2024
@mmorel-35 mmorel-35 deleted the golangci-lint/usestdlibvars branch October 28, 2024 21:00
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Oct 29, 2024
* main:
  chore: use require.Len instead of assert.Len (testcontainers#2854)
  chore: bump ryuk to 0.11.0 (testcontainers#2853)
  chore: enable usestdlibvars linter (testcontainers#2850)
  fix(compose): container initialisation (testcontainers#2844)
  fix!: data races (testcontainers#2843)
  fix: mongodb replicaset should work with auth (testcontainers#2847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Changes that do not impact the existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants