fix: simplify fully-qualified image names#2846
Merged
mdelapenya merged 10 commits intotestcontainers:mainfrom Oct 23, 2024
Merged
fix: simplify fully-qualified image names#2846mdelapenya merged 10 commits intotestcontainers:mainfrom
mdelapenya merged 10 commits intotestcontainers:mainfrom
Conversation
Images used in the tests, and in the modules are using a wrong Docker image prefix: docker.io. It's better to ask for "nginx:latest" and let the engine deal with the image references.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
changed the title
kiview
previously approved these changes
Oct 22, 2024
* main: fix(compose): race condition (testcontainers#2842)
stevenh
requested changes
Oct 22, 2024
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Just one issue and a few questions
Contributor
|
Oh if the concern is about *.io going away what about https://index.docker.io/v1/? |
Member
Author
No, because that's the correct index for the registry (Docker Hub) |
Co-authored-by: Steven Hartland <[email protected]>
stevenh
requested changes
Oct 23, 2024
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Looking good, just a few suggestions while you're making changes.
stevenh
approved these changes
Oct 23, 2024
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Oct 28, 2024
* main: chore: use require.(No)Error(t,err) instead of t.Fatal(err) (testcontainers#2851) fix: simplify fully-qualified image names (testcontainers#2846)
mdelapenya
added a commit
that referenced
this pull request
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes all the prefixes for
docker.iofrom the images used in 1) tests for the library, 2) modulesWhy is it important?
It's better to ask for "nginx:latest" and let the engine deal with the image references than to enforce an invalid docker registry.
If we wanted to be explicit about official images, we should have used
https://index.docker.io/v1/library/nginx:latestinstead.It also removes a bug when using Docker Desktop, as it considered those images were not accessible for the already used docker credentials.