fix: update module container struct name and missing imports#2831
Merged
mdelapenya merged 2 commits intotestcontainers:mainfrom Oct 18, 2024
Merged
fix: update module container struct name and missing imports#2831mdelapenya merged 2 commits intotestcontainers:mainfrom
mdelapenya merged 2 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Thanks for this! I'm going to add a few commits on top to avoid you suffer the burden of updating the modulegen tests 🙏 |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Oct 18, 2024
* main: feat: add yugabytedb module (testcontainers#2825) fix: update module container struct name and missing imports (testcontainers#2831)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Oct 18, 2024
* main: fix(reaper): refactor to allow retries and fix races (testcontainers#2728) chore: update ryuk to 0.10.2 (testcontainers#2833) feat: add yugabytedb module (testcontainers#2825) fix: update module container struct name and missing imports (testcontainers#2831) chore: replace 'assert' with 'require' (testcontainers#2827) chore: replace 'assert' with 'require' for critical checks (testcontainers#2824) chore: bump ryuk to latest release (testcontainers#2818) feat: add require for critical checks (testcontainers#2812)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the following in modulegen :
Containerleading to more idiomatic go (e.g postgres.Container)// run{{ $title }}Container {from the example test as we can use the name of the Example{{$entrypoint}} insteadWhy is it important?
New generated modules will be more idiomatic and won't have to fix imports manually
Related issues
No related issue but a request was made in this PR #2825 (comment) to name the container struct as
Containerfrom now on in preparation of v1How to test this PR
Generate a new module