feat: add etcd module#2788
Merged
mdelapenya merged 50 commits intotestcontainers:mainfrom Sep 30, 2024
Merged
Conversation
mdelapenya
added
the
feature
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* main: feat: support databend module (testcontainers#2779) chore: golangci-lint 1.61.0 (testcontainers#2787)
stevenh
requested changes
Sep 23, 2024
* main: chore: use a much smaller image for testing (testcontainers#2795) fix: parallel containers clean race (testcontainers#2790) fix(registry): wait for (testcontainers#2793) fix: container timeout test (testcontainers#2792) docs: document redpanda options (testcontainers#2789)
stevenh
requested changes
Sep 24, 2024
* main: fix(elasticsearch): wait for (testcontainers#2724)
stevenh
requested changes
Sep 27, 2024
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Making some good progress, nice catch on the network clean up.
stevenh
requested changes
Sep 27, 2024
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Just a few little things then I think we're there.
This reverts commit 1c4361b.
stevenh
requested changes
Sep 27, 2024
* main: feat: add dynamodb-local module (testcontainers#2799) fix(redpanda): wait for (testcontainers#2794)
stevenh
previously approved these changes
Sep 30, 2024
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
I would make that one last change to the internal run call, but it's a nit so approving anyway if you want to do in a follow up.
mdelapenya
added a commit
that referenced
this pull request
Oct 17, 2024
* main: chore: replace 'assert' with 'require' (#2827) chore: replace 'assert' with 'require' for critical checks (#2824) chore: bump ryuk to latest release (#2818) feat: add require for critical checks (#2812) chore(deps): bump release-drafter/release-drafter from 5.25.0 to 6.0.0 (#2805) feat: add etcd module (#2788) feat: add dynamodb-local module (#2799) fix(redpanda): wait for (#2794) fix(elasticsearch): wait for (#2724) chore: update dockercfg module (#2801)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a Go module for etcd, including clustering support. This module includes options to configure:
auto TLS for cluster-node communicationI removed it because it was not critical and causing issues in testsI followed https://etcd.io/docs/v3.5/op-guide/clustering/ to accomplish it.
The module exposes methods to talk to the the client and the peer endpoints.
Why is it important?
A new module for etcd, which could unblock adoption in other technologies (gofiber's etcd storage)