Skip to content

fix #2767 allow missing repository config#2771

Closed
daniel-meyer-dme wants to merge 1 commit intotestcontainers:mainfrom
daniel-meyer-dme:main
Closed

fix #2767 allow missing repository config#2771
daniel-meyer-dme wants to merge 1 commit intotestcontainers:mainfrom
daniel-meyer-dme:main

Conversation

@daniel-meyer-dme
Copy link
Copy Markdown

What does this PR do?

  • allow missing docher auth config file -- replace registry cache key with a key generated by any defined config
  • allow no provided config

Why is it important?

Configuring authentication is not mandatory as long as they can all be anonymously accessed.

Related issues

How to test this PR

  • Added a test & it should not break existing ones

- allow missing config file
-- replace registry cache key with a key generated by any defined config
- allow no provided config
@daniel-meyer-dme daniel-meyer-dme requested a review from a team as a code owner September 6, 2024 14:46
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 6, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit e6f5bbf
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66db15b75e24b300087956db
😎 Deploy Preview https://deploy-preview-2771--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenh
Copy link
Copy Markdown
Contributor

stevenh commented Sep 7, 2024

I extend this fixing some additional edge cases here #2772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Consider handling non-existent ~/.docker/config.json

2 participants