chore: avoid using of log.Fatal in main in tests#2739
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Aug 21, 2024
stevenh:fix/log-fatal
Merged
chore: avoid using of log.Fatal in main in tests#2739mdelapenya merged 1 commit intotestcontainers:mainfrom stevenh:fix/log-fatal
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/log-fatal
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Remove use of log fatal which prevents defers. Correct order of Write and WriteHeader a update test to validate the correct behaviour, leveraging require.
mdelapenya
approved these changes
Aug 21, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I'm changing the title to chore as this is not user-facing, but internal to the tests of the project.
mdelapenya
changed the title
mdelapenya
changed the title
mdelapenya
added a commit
that referenced
this pull request
Aug 22, 2024
* main: chore(deps): bump github/codeql-action from 3.24.9 to 3.25.15 (#2677) fix: use of log.Fatal in main (#2739) chore: prepare for next minor development cycle (0.34.0) chore: use new version (v0.33.0) in modules and examples fix: authentication tests on WSL (#2706) fix(registry): compatibility with WSL (#2705)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 26, 2024
* main: chore(deps): bump minimal Go version from 1.21 to 1.22 (testcontainers#2743) chore(deps): bump github/codeql-action from 3.24.9 to 3.25.15 (testcontainers#2677) fix: use of log.Fatal in main (testcontainers#2739) chore: prepare for next minor development cycle (0.34.0) chore: use new version (v0.33.0) in modules and examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove use of log fatal which prevents defers and correct order of Write and WriteHeader.