fix(elasticsearch): wait for#2724
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Sep 27, 2024
stevenh:fix/elasticsearch-wait
Merged
fix(elasticsearch): wait for#2724mdelapenya merged 1 commit intotestcontainers:mainfrom stevenh:fix/elasticsearch-wait
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/elasticsearch-wait
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Aug 12, 2024
mdelapenya
reviewed
Aug 12, 2024
Merged
Contributor
Author
This is actually a bug, I missed the circular dependency between the ready and wait conditions. There's two options:
|
Contributor
Author
|
@mdelapenya rebased on top of the new |
mdelapenya
reviewed
Sep 26, 2024
mdelapenya
reviewed
Sep 26, 2024
mdelapenya
previously approved these changes
Sep 26, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
There is just one comment regarding adding the basic auth to the wait strategy twice.
Other than that, LGTM, thanks!
Wait for the HTTP port to be available to prevent random failures when the container isn't fully started and returns 503 errors.
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 27, 2024
* main: fix(elasticsearch): wait for (testcontainers#2724)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 27, 2024
* main: fix(redpanda): wait for (testcontainers#2794) fix(elasticsearch): wait for (testcontainers#2724)
mdelapenya
added a commit
that referenced
this pull request
Oct 17, 2024
* main: chore: replace 'assert' with 'require' (#2827) chore: replace 'assert' with 'require' for critical checks (#2824) chore: bump ryuk to latest release (#2818) feat: add require for critical checks (#2812) chore(deps): bump release-drafter/release-drafter from 5.25.0 to 6.0.0 (#2805) feat: add etcd module (#2788) feat: add dynamodb-local module (#2799) fix(redpanda): wait for (#2794) fix(elasticsearch): wait for (#2724) chore: update dockercfg module (#2801)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for the HTTP port to be available to prevent random failures when the container isn't fully started and returns 503 errors.