chore: fix nginx request failures in tests#2723
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Aug 13, 2024
stevenh:fix/nginx-request-failures
Merged
chore: fix nginx request failures in tests#2723mdelapenya merged 1 commit intotestcontainers:mainfrom stevenh:fix/nginx-request-failures
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/nginx-request-failures
Conversation
Fix tests which make http requests to nginx container by switching to http startup check, which avoids issues on nginx being able to respond to requests.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Could you elaborate a bit more on the issues experienced here? I see the value in the HTTP call instead of the listening port, but I'd like to understand more the failures here. |
Contributor
Author
CI was failing with a number of different errors, the main one I recall being EOF, switching to a HTTP prevented any further occurrences of this. |
mdelapenya
changed the title
mdelapenya
added a commit
that referenced
this pull request
Aug 16, 2024
* main: fix: config via environment (#2725) fix(redpanda): race condition on port check (#2692) fix: logging restart (#2697) fix!: docker authentication setup (#2727) chore: improve error wrapping (#2720) chore: run make tests in verbose mode (#2734) chore(deps): bump github.com/docker/docker from 27.1.0+incompatible to 27.1.1+incompatible (#2733) fix(kafka): port race on start (#2696) docs: fix broken doc tags (#2732) fix: nginx request failures (#2723) fix(compose): container locking (#2722) fix(wait): log test timeout (#2716) chore: increase timeout values (#2719) chore: remove unused parameters (#2721) chore(mockserver): silence warning about internal port (#2730) feat(wait): skip internal host port check (#2691)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests which make http requests to nginx container by switching to http startup check, which avoids issues on nginx being able to respond to requests.