Skip to content

feat: add logging on image pull error#272

Merged
gianarb merged 1 commit intotestcontainers:masterfrom
tobiaszheller:feat/add-logging-on-image-pull-error
Dec 24, 2020
Merged

feat: add logging on image pull error#272
gianarb merged 1 commit intotestcontainers:masterfrom
tobiaszheller:feat/add-logging-on-image-pull-error

Conversation

@tobiaszheller
Copy link
Copy Markdown
Contributor

Right now when something is wrong with pulling image, for example:

Error response from daemon: unauthorized: You don't have the needed permissions to perform this operation, and you may have invalid credentials. To authenticate your request, follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication

there is no indication that any action is happening. This log will additional debug information if something is wrong.

@gianarb
Copy link
Copy Markdown
Member

gianarb commented Dec 24, 2020

Thanks a lot! You have also added the retry! Good job!

@gianarb gianarb merged commit 5cce89b into testcontainers:master Dec 24, 2020
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants